Skip to content

Conversation

@cedrik-fuoco-adsk
Copy link
Contributor

@cedrik-fuoco-adsk cedrik-fuoco-adsk commented Dec 2, 2025

SG-40093 - LTS BRANCH - Fix crash when the pixel format is unknown in frames and pinning OpenGL-Registry

Linked issues

n/a

Summarize your change.

Cherry-picked from the main branch:

6fc6012 (AVI crash)
2787ab2 (pinning OpenGL-Registry on the last known functional build for OpenGL-Registry)

This is merging into RB-2.2.0-VFX2023

Describe the reason for the change.

Back porting two fixes for LTS branch

@cedrik-fuoco-adsk cedrik-fuoco-adsk changed the title LTS BRANCH - Fix crash when the pixel format is unknown in frames SG-40093 - LTS BRANCH - Fix crash when the pixel format is unknown in frames Dec 2, 2025
…Foundation#794)

### Fix crash when the pixel format is unknown in frames

### Linked issues
n/a

### Summarize your change.
Save the pixel format when the media is opened and use that as fallback
if the pixel format of some frames can not be detected. This assumes
that there is a pixel format when opening the file and if it does not
have one, it will fail at that point before getting to
`decodeImageAtFrame`.

### Describe the reason for the change.
OpenRV was crashing on some AV1 media because the pixel format was
unknown for all the frames.

### Describe what you have tested and on which operating system.
MacOS

### Add a list of changes, and note any that might need special
attention during the review.

### If possible, provide screenshots.

Signed-off-by: Cédrik Fuoco <[email protected]>
Signed-off-by: Cédrik Fuoco <[email protected]>
…cademySoftwareFoundation#958)

### Pin the commit for OpenGL-Registry (downloaded when building GLEW)

### Linked issues
n/a

### Summarize your change.

To fix this, `glew.cmake` will clone the `OpenGL-Registry` and checkout
the latest working commit before executing the `make` command. It will
prevent the build system of GLEW to checkout the master of
`OpenGL-Registry`, and it will continue as usual.

### Describe the reason for the change.
A recent changes in https://github.com/KhronosGroup/OpenGL-Registry
(KhronosGroup/OpenGL-Registry@d38ff69)
is causing C++ redefinition of typedef which causes a bunch of errors.

See an opened issue in GLEW repository:
nigels-com/glew#449

### Describe what you have tested and on which operating system.
CI

---------

Signed-off-by: Cédrik Fuoco <[email protected]>
@cedrik-fuoco-adsk cedrik-fuoco-adsk changed the title SG-40093 - LTS BRANCH - Fix crash when the pixel format is unknown in frames SG-40093 - LTS BRANCH - Fix crash when the pixel format is unknown in frames and pinning OpenGL-Registry Dec 2, 2025
Copy link
Contributor

@bernie-laberge bernie-laberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Cédrik Fuoco <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants